tart icon indicating copy to clipboard operation
tart copied to clipboard

Prefer official Homebrew distribution

Open umireon opened this issue 2 years ago • 7 comments

I've added tart to the official Homebrew repository. https://github.com/Homebrew/homebrew-core/pull/114571

umireon avatar Nov 10 '22 11:11 umireon

Since Tart's com.apple.vm.networking entitlement was recently approved, I assume it means in order to use bridged networking in the future, it would need to be codesigned with Cirrus Labs' certificate and including their provisioning profile.

I might be misunderstanding some of this, but I think it would mean that brew's ad-hoc signed distribution wouldn't be able to have all of the same functionality as the one distributed as binaries in this repo's releases. Just a thought and some fodder for discussion :)

timsutton avatar Nov 10 '22 13:11 timsutton

It's nice to see Tart being available in Homebrew directly, but this is somewhat a regression due to slower release time, the Homebrew's repository and review process being the bottleneck here.

Perhaps leaving both options to install Tart in README.md and some explanation on how to choose between the two would be a nice trade-off here.

edigaryev avatar Nov 10 '22 15:11 edigaryev

Homebrew's review process is almost immediate, and it won't be a regression, I think.

umireon avatar Nov 10 '22 15:11 umireon

Especially for version updates, they have update detectors and maintainers and contributors are eager to keep every formula up to date.

umireon avatar Nov 10 '22 15:11 umireon

Especially for version updates, they have update detectors and maintainers and contributors are eager to keep every formula up to date.

Good to know that!

But still, we need to keep in mind that it's not immediate from Tart's side, like it is now. One has to do two things now, instead of one. I wonder if this can be automated somehow.

edigaryev avatar Nov 10 '22 15:11 edigaryev

Appreciate the effort of putting out tart into the official Homebrew repository! I wish you would've create an discussion first though!

Two things will not work for Tart here. First, we do need signing with our certificate to get the elevated network entitlements. But most importantly we need signing with some valid developer certificate (and not self-signed) so users don't need to allow access to Keychain every time you update Tart.

On top of the things, we need an automated way to propagate updates upon release. Right now we use Goreleaser. What's the story of automatically creating PR for updates to Homebrew core?

fkorotkov avatar Nov 10 '22 16:11 fkorotkov

There is a fully-automated command to create updating PR.

https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula

umireon avatar Nov 10 '22 16:11 umireon

Closing it since it's unclear how to support the signing part since it requires private keys from our side. Either the homebrew formula should download prebuilt binaries or we should just remove to lower the confusion.

fkorotkov avatar Dec 14 '22 20:12 fkorotkov