cirrus-ci-docs icon indicating copy to clipboard operation
cirrus-ci-docs copied to clipboard

Make projects on the left sidebar clickable by middle mouse button

Open AlexWayfer opened this issue 4 years ago • 5 comments

Expected Behavior

I want to open different projects from the left sidebar on cirrus-ci.com in new tabs by clicking via middle mouse button on them.

Real Behavior

Nothing.

Related Info

  • [x] Website issue
    • Link to page: https://cirrus-ci.com/

image

AlexWayfer avatar Jul 14 '20 15:07 AlexWayfer

Thank you! :clap:

AlexWayfer avatar Jul 14 '20 16:07 AlexWayfer

@fkorotkov here’s why a tags would be more effective - they are meant to handle these things on the browser end. It will be easier to fix by just switching over.

Not only that, but any keyboard shortcuts, etc supported by that browser will just work with a tags.

RDIL avatar Jul 28 '20 19:07 RDIL

Agreed, need to investigate how tags are playing along with the SPA nature of the front end (if there is a refresh when you click on a task from a build page or simply a GraphQL call like right now).

fkorotkov avatar Jul 28 '20 19:07 fkorotkov

I’ll try migrating this to an a tag later today, and if it all works as expected then maybe we can look in to switching the rest of the codebase.

RDIL avatar Jul 28 '20 19:07 RDIL

Update on this:

So I tried implementing it, but it messed up the styling, and made React fail the DOM tree tests, because a tags can't be the parent of a table row.

So yeah, this sadly didn't work.

RDIL avatar Aug 01 '20 02:08 RDIL