cirrus-ci-docs icon indicating copy to clipboard operation
cirrus-ci-docs copied to clipboard

Mark "cache" and "artifacts" tasks as such

Open dotdoom opened this issue 5 years ago • 6 comments

Description

Right now in the Build log, flutter_cache and app_artifacts tasks will be displayed as "flutter" and "app" in the Build tasks list. By the way, the counterpart of flutter_cache will be displayed as "Upload 'flutter' cache", which is great.

It would be convenient to have them marked as "cache" and "artifacts", respectively (e.g. "Download 'flutter' cache" and "Upload 'app' artifacts").

Although if this is WAI to give the user more freedom, I can also understand. But then I have to rename them into flutter_cache_cache and app_artifacts_artifacts to give a hint to someone looking at the logs.

dotdoom avatar Sep 08 '19 20:09 dotdoom

Something to mention is, I do understand that task names are identifiers which can be used in API, badges and .cirrus.yml to reference to the tasks themselves. Therefore it's important to keep the names in the build log non-ambiguous.

Perhaps it's possible to make this a subtle UI-only feature and put the "task type" somewhere where it will not be confused as a part of task name?

dotdoom avatar Sep 08 '19 20:09 dotdoom

@dotdoom do you think adding icons for each type of the instruction will help?

fkorotkov avatar Sep 13 '19 16:09 fkorotkov

I feel like then you would need icons for all the different types of tasks because it would look out of place otherwise

RDIL avatar Sep 13 '19 16:09 RDIL

Icons do sound good, especially if they come with tooltips!

dotdoom avatar Sep 16 '19 20:09 dotdoom

I will try to do this now, @fkorotkov what is the class name of this component? Screenshot 2019-10-11 at 9 38 55 AM

RDIL avatar Oct 11 '19 13:10 RDIL

Check TaskCommandList

fkorotkov avatar Oct 11 '19 14:10 fkorotkov