sample-rpc-go compile error

compile error

Open huahuayu opened this issue 6 years ago • 3 comments

main.go line 84 causes a compile error, please check

Aug 22 '18 15:08 huahuayu

change client.go line91 from: func (c *Client) Execute(ctx context.Context, name string) (msg string, err error) {

to func (c *Client) Execute(name string) (msg string, err error) {

will make the compile pass, it seems ctx is not used in Execute function, why keep it in the arguments?

Aug 23 '18 00:08 huahuayu

Hey @huahuayu ,

you're right! It's not being used.

Could you please send a PR addressing that?

thx!

Aug 23 '18 00:08 cirocosta

do it later

Aug 23 '18 11:08 huahuayu