counsel-ffdata icon indicating copy to clipboard operation
counsel-ffdata copied to clipboard

Support for Chromium-based browsers

Open a13 opened this issue 6 years ago • 7 comments

is it possible to add the support for Chromium?

the db filename is ~/.config/$APPNAME/Default/History in most cases

appname could be chromium, google-chrome, vivaldi etc

a13 avatar Jul 04 '19 15:07 a13

I seldom use Chromium, so I can't help to maintain the code part of chromium or other browser than Firefox. But it may be a good idea to make this package more extensible.

cireu avatar Jul 05 '19 11:07 cireu

BTW, I am working on a new feature -- a generic API to make a generic async candidate interface. If that work can be done, it may also help counsel-ffdata to load data asynchronously.

cireu avatar Jul 05 '19 11:07 cireu

You can make the code more generic, since both firefox and chromium use sqlite dbs, so people can add support for alternative browsers easier. There's a simple history jump script I wrote a long time ago so you can get my idea: https://github.com/a13/scripts/blob/master/webjump.sh

a13 avatar Jul 07 '19 11:07 a13

I've taken a look at the code again, and the task looks even simpler: just make :query-stmt customizable (for both bookmarks and history items).

a13 avatar Jul 07 '19 11:07 a13

Would you like to open a PR?

cireu avatar Jul 07 '19 11:07 cireu

@a13 https://github.com/a13/scripts/blob/master/webjump.sh#L19

Is profile.ini a part of Firefox or it's your own file? I can't find such file in my $HOME directory

cireu avatar Jul 07 '19 11:07 cireu

Is profile.ini a part of Firefox or it's your own file?

was a part of firefox, I don't know if there's one now

Would you like to open a PR?

Maybe a little bit later, kinda busy now

a13 avatar Jul 07 '19 12:07 a13