Argument Validation for circleci tests split

[sshaw]

Description

Invalid --timings-type option was passed to circleci tests run. This resulted in the timings not being found. An invalid argument should result in a non-zero exit code, not execution of the command.

Location

Is there even online documentation for circleci tests run's arguments? I had to SSH in and run --help 😕

Steps to Reproduce

We were splitting test as follows:

circleci tests run --command="something amaaaaaazing" --split-by=timings  --timings-type=name

Note the --timings-type=name. This is incorrect and should be filename.