circe-yaml icon indicating copy to clipboard operation
circe-yaml copied to clipboard

Support maxAliasesForCollections override

Open hcdeng opened this issue 4 years ago • 3 comments

SnakeYaml defaults "maxAliasesForCollections" to 50, and supports overriding this value via https://www.javadoc.io/doc/org.yaml/snakeyaml/latest/org/yaml/snakeyaml/LoaderOptions.html. This would probably be implemented the same way as https://github.com/circe/circe-yaml/issues/120.

We have a project that parses yml files with more than 50 aliases - currently using a workaround for this.

hcdeng avatar Aug 31 '20 21:08 hcdeng

Starting work on this

hcdeng avatar Sep 01 '20 17:09 hcdeng

Would very much appreciate if you could implement https://github.com/circe/circe-yaml/issues/120 at the same time, but totally understand if it requires significant extra effort

ajj-stripe avatar Jul 19 '21 20:07 ajj-stripe

Doesn't seem like too much work, but the PR for maxAliasesForCollections is (hopefully) only a couple button clicks away from getting merged. Once it's in, adding https://github.com/circe/circe-yaml/issues/120 should be pretty small/straightforward. If it happens in the next couple of weeks, I should have time to tackle it.

hcdeng avatar Jul 19 '21 21:07 hcdeng

This is resolved by https://github.com/circe/circe-yaml/releases/tag/v0.14.2

jeffmay avatar Mar 02 '23 21:03 jeffmay