wc3-ts-template icon indicating copy to clipboard operation
wc3-ts-template copied to clipboard

Published 20 hours ago • verified publisher icon cipherxof

Peer dependency issue when using latest package version

Open bertman12 opened this issue 1 year ago • 5 comments

`
"typescript": "5.0.4", "typescript-to-lua": "^1.15.1",

` Latest version of typescript-to-lua uses typescript 5.2.2, however we use 5.0.4 causing peer dependency issue.

Can we change to this? "typescript-to-lua": "1.15.1",

bertman12 avatar Oct 22 '23 16:10 bertman12

Can I make a PR to implement the change? I think I need permissions to create a branch and then create a PR.

peer dependency error

bertman12 avatar Dec 23 '23 05:12 bertman12

You can yeah. We also need to remove package-lock.json from gitignore.

cipherxof avatar Dec 23 '23 05:12 cipherxof

Alright, still getting permission denied.

bertman12 avatar Dec 23 '23 05:12 bertman12

Alright, still getting permission denied. git-permission-denied

You need to fork the repo and make the changes on your own branch, then create a pull request.

cipherxof avatar Dec 23 '23 06:12 cipherxof

PR created

bertman12 avatar Dec 23 '23 09:12 bertman12