wc3-ts-template icon indicating copy to clipboard operation
wc3-ts-template copied to clipboard

Remove war3-transformer

Open kaszim opened this issue 1 year ago • 2 comments

Even if war3-transformer was great, it causes issues because custom transformers isn't really supported out of the box for typescript. Fixed it by doing a quick hack and moving the compile time functionality to a script file instead.

While at it I updated packages.json and ensured that the lock file is commited too. Fixes #17.

kaszim avatar Aug 31 '23 19:08 kaszim

Can you explain what issues these changes are intended to solve? While transformers aren't yet natively supported by TypeScript, they are by TypeScriptToLua which is what this template uses.

cipherxof avatar Sep 01 '23 00:09 cipherxof

The main issue is that in its current state master is broken and cannot be used. Mostly because there was no lock file, therefore even downgrading doesn't really work. These changes just ensures everything works as intended and removes the reliance on specific typescript versions.

There also was some issue relating to changing the model of the footman. Was resolved by simply adding a w3u file and resaving the map in the latest editor version.

I do understand if you wish not to merge these changes as it really changes the structure of the template.

kaszim avatar Sep 14 '23 14:09 kaszim