Alexander Scheel

Results 588 comments of Alexander Scheel

@SixTanDev I'm going to go ahead and close this one as https://github.com/openbao/openbao/issues/787 now has the RFC, which will track implementation now. :-) Thank you for raising this one and hopefully...

\o hey @vhespanha! Interested in finishing this up? Looks like our changes to `ssh` have caused this to conflict, sadly.

@jficz To be clear, I don't think I'd remove the audit tunable from `sys/mounts/:path/tune` today, I'd just start marking it deprecated and introduce the new version. Thus it shouldn't be...

@jficz Does `log_raw` on the audit device configuration work for you? Or are there particular non-sensitive fields you want reserved (or, sensitive fields you want HMAC'd)? But otherwise this makes...

This is also not something I'm likely to get to in a reasonable time; feel free to tackle this one if you're interested.

\o hey @GeorgeJahad, sorry, been a busy time :-) The `OptMarshaler`/`MarshalJSONWithOptions` seems entirely unused so I'm not concerned about supporting it. Time is a good counter example since it marshals...

Fixed by #887, thanks @GeorgeJahad!

@driif Do you want to move this to a PR?

@driif Another comment -- I think kubernetes service registration will need to emit this label? https://github.com/openbao/openbao/blob/0b14ac0b58df90852e908601ab5d8a14d709fea2/serviceregistration/kubernetes/service_registration.go#L20 (in addition to `openbao-active=false`) to indicate that they are read-only standby nodes that _can_...

@klaus-sap I don't think this is as bad as @driif makes it out to be in Raft. What he's describing is the cache invalidation mechanism. If your write ends at...