cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Message author doesn't change after sending message with no content

Open Roki100 opened this issue 3 years ago • 2 comments

Describe the bug

When chatting e.g. in DMs with user you can send message with no content and pretty much "chat as him"

Reproduction

  1. open element
  2. /devtools
  3. send custom event
  4. do not edit the json at all but just set the type to m.room.message
  5. send the event
  6. check cinny, the message should not be visble at all and if last message was from user, sending a message will make it appear like he sent it (spoiler: he didn't)

Expected behavior

The message should appear and be empty

Platform and versions

Cinny version: 2.1.1
Matrix Homeserver: matrix.org

Additional context

idk testing and this turns out to be a cinny bug (sending such event should be possible in DMs if it fails in other rooms)

Roki100 avatar Aug 09 '22 19:08 Roki100

As per spec body is required, and no client sends an empty message. Using devtools you can break just everything.

kfiven avatar Aug 10 '22 15:08 kfiven

As per spec body is required, and no client sends an empty message. Using devtools you can break just everything.

well yeah, but that should still be clasified as a bug as the client should handle unsupported messages/events and such

Roki100 avatar Aug 10 '22 18:08 Roki100