cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Add button to start thread on reply

Open filipesmedeiros opened this issue 8 months ago • 3 comments

Description

The only thing the above PR does is add a button to the message popup if it is not yet inside a thread to start a thread. It looks like this:

Screenshot showing the new button added by this PR, on the message hover menu

The button only shows up if the message hovered is not inside a thread itself. It works nicely. The way threads in Matrix works makes it so that if you reply to a message that is already a thread root, it doesn't matter. The new threaded reply will just be added to the end of the thread. Nice!

Fixes #2308

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

filipesmedeiros avatar May 07 '25 10:05 filipesmedeiros

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar May 07 '25 10:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

filipesmedeiros avatar May 07 '25 10:05 filipesmedeiros

Preview: https://2320--pr-cinny.netlify.app ⚠️ Exercise caution. Use test accounts. ⚠️

github-actions[bot] avatar May 26 '25 02:05 github-actions[bot]

@ajbura added a screenshot of the new icon to the original post :)

filipesmedeiros avatar Jul 22 '25 11:07 filipesmedeiros

Should the new thread button also be added to the context menu? To me it would make sense that the hover/quickaccess-popup is a subset of the buttons in the full pop-up menu, and so it feels a bit weird that something is only in the quick-access popup.

GimleLarpes avatar Jul 23 '25 10:07 GimleLarpes

image

Added @GimleLarpes :) Thanks for the great suggestion!

filipesmedeiros avatar Jul 23 '25 11:07 filipesmedeiros

~~Pedantic note, but the T in "Reply in Thread" should be capitalized 😅~~ nvm I can't read lol

GimleLarpes avatar Jul 23 '25 11:07 GimleLarpes