Allow more servers to be added to the list in the explore tab

[gingershaped]

Description

This PR saves servers added to the Explore tab in account storage, allowing the list of explorable servers to be customized by the user.

Currently there is no way to explore a server without saving it to the list. Perhaps another button could be added below the current "Add Server" button to view a server without saving it?

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings

[github-actions[bot]]

Preview: https://2268--pr-cinny.netlify.app ⚠️ Exercise caution. Use test accounts. ⚠️

[gingershaped]

added server will appear in the same list which include featured server, but we can filter featured server so they do not have duplicate from added one.

I think there should be a visual distinction between featured servers and added servers. If the only difference is the absence of the "remove" button, users could become confused as to why they can't remove them.

[gingershaped]

adding and removing servers works good. but the redesign of explore drawer makes it little confusing.

What do you find confusing about this design? I'd like to see if I can resolve your concerns. In my opinion it's an improvement over the previous design because it has clearer separation between featured servers and rooms which the user cannot remove and added servers which the user has control over. I also prefer having separate "Add server" and "Explore server" buttons, because that allows the "Explore server" button to be highlighted to indicate more clearly to the user that the rooms they're looking at don't belong to a server in the list.

[kfiven]

Hi, these changes are completely altering the designed UX we already have in the app.

1. The left side is for servers and right space is for rooms and spaces, now it's a mix.
2. The public directory server is unnecessary as that's essentially a server as well and can be added in existing list.
3. The featured and user's own home server should have more visibility as it is now.
4. Server icons are inconsistent (eye, home, bulb, search).

IMHO saving of new searches can be easily achieved by just with the "Bookmark and View" button saving the searched server below the already provided list.

[gingershaped]

IMHO saving of new searches can be easily achieved by just with the "Bookmark and View" button saving the searched server below the already provided list.

Your proposed approach is exactly the one I took originally, but @ajbura expressed dissatisfaction with it. The current UX is my attempt to resolve their criticisms.

[kfiven]

I am sorry but all I can see is that they are suggesting staying close to the original design from start:

Previous design was good, we can just add the two button in + Add server dialog, one to Save (primary) and other to View (soft primary). https://github.com/cinnyapp/cinny/pull/2268#pullrequestreview-2727794788

i feel like keeping it close to the existing design will be more beneficial. https://github.com/cinnyapp/cinny/pull/2268#pullrequestreview-3170916125

[gingershaped]

I am sorry but all I can see is that they are suggesting staying close to the original design from start:

Previous design was good, we can just add the two button in + Add server dialog, one to Save (primary) and other to View (soft primary). https://github.com/cinnyapp/cinny/pull/2268#pullrequestreview-2727794788

i feel like keeping it close to the existing design will be more beneficial. https://github.com/cinnyapp/cinny/pull/2268#pullrequestreview-3170916125

I will revert my changes to my earlier design.

[github-actions[bot]]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[ajbura]

Please resolve the merge conflicts.