cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Desktop notifications don't contain the message

Open Salamandar opened this issue 1 year ago • 6 comments

Describe the bug

Up until the latest release, desktop notifications contained the beginning of the message. So you'd know if it was useful to go to the cinny tab. See https://github.com/cinnyapp/cinny/blob/9ecb233763048c730d24ddacecc8c002d3c8fc89/src/client/state/Notifications.js#L272

Now the notification just contains "new notification from X" (see https://github.com/cinnyapp/cinny/blob/e68c56b334107862ab2eec5635c11c40c050f00b/src/app/pages/client/ClientNonUIFeatures.tsx#L157)

Now you need to go into the cinny app to see if this notification is relevant or if it just interrupted your previous activity.

Reproduction

No response

Expected behavior

A useful notification with the content of the message, as before.

Maybe a configurable behaviour if you want to hide the content of the message for privacy purposes.

Platform and versions

Cinny version: v4.0

Additional context

No response

Salamandar avatar Aug 09 '24 10:08 Salamandar

would love for this to be configurable, similar to most messaging apps on mobile where you can choose whether to show content or keep it private.

williamkray avatar Aug 09 '24 16:08 williamkray

I brought this up in the chat at some point before and it's supposedly intentional, so I'll 1+ this issue.

regalialong avatar Aug 10 '24 18:08 regalialong

I also would love to have the option to hide/show the messages content in the notification so I can choose my own security/usability balance :)

Lxtharia avatar Oct 28 '24 22:10 Lxtharia

For personal use I made a patch

https://github.com/LevitatingBusinessMan/cinny/commit/1012c07021b82337f2cd92106eec70793c64b3d8

LevitatingBusinessMan avatar Nov 30 '24 23:11 LevitatingBusinessMan

How are you willing to tackle this @ajbura. Should it be a configurable setting?

LevitatingBusinessMan avatar Feb 19 '25 12:02 LevitatingBusinessMan

@LevitatingBusinessMan I haven't think about it yet. But probably yes, it may require setting toggle.

ajbura avatar Feb 19 '25 13:02 ajbura