cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Add basic `m.thread` support

Open greentore opened this issue 1 year ago • 4 comments

Description

Adds basic m.thread support as described in MSC3440. Support in this case means that replying to a threaded message will place the reply in the thread in clients that support them.

Partially fixes #257

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

greentore avatar Jul 23 '23 23:07 greentore

Preview: https://1349--pr-cinny.netlify.app ⚠️ Exercise caution. Use test accounts. ⚠️

github-actions[bot] avatar Jul 23 '23 23:07 github-actions[bot]

any updates?

naskya avatar Nov 16 '23 02:11 naskya

Is any help needed here? I can try to contribute if you think I could help :)

filipesmedeiros avatar Dec 09 '23 13:12 filipesmedeiros

Can the reviewers with write access please look at this? This has been open for quite some time and threads are a noticeable missing feature

JuliaSoriaSmith avatar May 23 '24 00:05 JuliaSoriaSmith

I added threaded reply indicators inspired by element-x. Should resolve https://github.com/cinnyapp/cinny/issues/1871.

greentore avatar Aug 06 '24 04:08 greentore

i'm not an approver but i've briefly tested the netlify deployment of this PR and it looks fantastic, i'm very eager to see this merged.

seems like the quoted message doesn't get truncated with elipses (...) properly, and runs off the right hand side of the screen.

image

williamkray avatar Aug 07 '24 15:08 williamkray

same messages in stable cinny:

image

williamkray avatar Aug 07 '24 15:08 williamkray

@williamkray looks like I broke it again. Thanks for the report.

greentore avatar Aug 07 '24 15:08 greentore

looks good after the fix!

williamkray avatar Aug 07 '24 17:08 williamkray

I converted rem units to equivalent toRem calls as requested. I also considered disabling thread support in sdk, but resulting unthreaded read receipts mark all threads in the room as read in threaded clients, which may be considered undesired behavior.

greentore avatar Aug 14 '24 18:08 greentore