cinny icon indicating copy to clipboard operation
cinny copied to clipboard

Combine cinny-desktop

Open HybridEidolon opened this issue 1 year ago • 3 comments

Description

Merge the cinny-desktop tree into the main app tree, allowing the Tauri app to be built inside the tree with the app itself. Provides #1323 .

This merge intentionally preserves the commit history of cinny-desktop to maintain authorship information for AGPL-3 compliance.

Fixes #

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

(Most N/A)

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

HybridEidolon avatar Jul 02 '23 02:07 HybridEidolon

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
:white_check_mark: @kfiven
:x: @kubo6472
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Jul 02 '23 02:07 github-actions[bot]

The merged README wouldn't make sense anyway. You can drop my commit as I won't be signing any kind of CLA, thanks. @HybridEidolon

kubo6472 avatar Jul 02 '23 08:07 kubo6472

I think there is merit for merging the two together, so you can work on it as a single package with a unified review process. It would nice to be able to fork this repo and compile to a desktop app whilst still having the ability to post changes.

JuliaSoriaSmith avatar Apr 17 '24 14:04 JuliaSoriaSmith

Closing as we do not have any plans to combine these two and that's why we started the desktop repo as separate in starting.

kfiven avatar May 22 '24 12:05 kfiven