cinny
cinny copied to clipboard
Use images for rooms too, not only DMs.
Description
Fixes #107
Shows the room image if available. For now it's only icons and all the rooms have the same.
Type of change
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
Here's what it looks like
I also quite like the current look of the UI. Could we hide this behind a slider in appearance perhaps?
Would love to have this merged!
Today I came to github only to fill a feature request on topic... but found this PR. I believe group avatars should be visible (isn't it their purpose?); it's so common and familiar for ~my friends~ potential users migrating from other popular messengers.
Current UI reminds channels in slack/discord spaces though — is it an actual motivation? In that case I do agree it's a nice feature, but I feel that:
-
it's only reasonable in spaces, not in global "home" list. Spaces do feel like slack/discord servers and UI with no room avatars could be fine for them because
- spaces/servers already have icons
- there are usually not much rooms within single space/server (easier to navigate) and they share common theme & community (lower risks of choosing wrong room)
- having clean screen is also good (BTW, some discord servers use emoji in room names to compensate absence of icons)
But "home" space feels more like a usual "chat-oriented" (rather than "space-oriented") messenger (Telegram, WhatsApp...) — a place where divergent uncategorized chats (communities) are shuffled together. This factor makes visual distinction more valuable. I'd say rooms outside of spaces are kind of "mini spaces" themself.
-
despite what has been said above, even with this PR being merged, space admins will be able to imitate slack/discord's look and feel if they like to... simply by not setting any room avatars and therefore keeping default hashtag icons!
I don't really want my matrix client hiding room avatars from me. And I really like Cinny, wish I could suggest it to my friends as a feature-rich alternative to messaging apps that do not respect privacy.
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA