cinny-desktop icon indicating copy to clipboard operation
cinny-desktop copied to clipboard

Add ctrl+q and prepare ctrl+w keybinds

Open hugeblank opened this issue 1 year ago • 4 comments

Description

Fixes #204

Lifts event handler logic from paste image support (#167).

Includes some commented out logic for compatibility with systray (#166) when/if merged. Requires TRAY_LABEL in tray.rs be exposed as public.

If I catch that the referenced PRs get merged before this one I'll resolve conflicts and uncomment code as necessary. That said, this PR on its own is ready to be merged if the maintainers want to handle the conflicts and changes I've mentioned.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

hugeblank avatar Sep 26 '23 21:09 hugeblank

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Sep 26 '23 21:09 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

hugeblank avatar Sep 26 '23 21:09 hugeblank

recheck

hugeblank avatar Sep 26 '23 21:09 hugeblank

Decided to build my PR and test it in production and it doesn't work. This threw me off because it worked in the dev environment. There's an open issue tracking the inability to set global shortcuts on wayland (tauri-apps/tauri#3578), and I think that's the issue now. Guess this PR is blocked until it gets fixed. Fun.

hugeblank avatar Sep 26 '23 22:09 hugeblank