libremetaverse icon indicating copy to clipboard operation
libremetaverse copied to clipboard

_packetInbox unexpectedly null under certain sequence of events

Open aiwaiwa opened this issue 2 years ago • 1 comments

This is observed after a (vaguely observed) failed teleport event and an attempt to log out when the network seems to already log out the avatar. The evidence of this is a log message Ignoring RequestLogout(), client is already logged out that precedes the outcome below in the NetworkManager public void Shutdown(DisconnectType type, string message).

image

Knowing how flimsy the logging out and teleporting is, I wonder if this can be somehow addressed internally in the library, or rather it would be advisable to intercept the error on a higher level?

The stack seems to begin with the Logout():

 	LibreMetaverse.dll!OpenMetaverse.NetworkManager.Shutdown(OpenMetaverse.NetworkManager.DisconnectType type, string message) Line 856	C#
>	LibreMetaverse.dll!OpenMetaverse.NetworkManager.Logout() Line 729	C#

aiwaiwa avatar Jan 15 '23 17:01 aiwaiwa

Thank you for taking the time to improve LibreMetaverse! We will review your contribution shortly.

github-actions[bot] avatar Jan 15 '23 17:01 github-actions[bot]

Just going to ignore the exception. If the packetInbox is already destroyed and we're shutting down, it's a non-issue, teardown fragility aside. Resolved with def5ea19

cinderblocks avatar Jun 30 '24 13:06 cinderblocks