teslausb icon indicating copy to clipboard operation
teslausb copied to clipboard

tidying up

Open rtanaka opened this issue 6 years ago • 2 comments

note - if you accept this PR, i'll need your help to add the links I removed from the README into the wiki. it would be good to add another option to purchase the raspberry pi zero from sparkfun since the amazon one is not cost effective - https://www.sparkfun.com/products/14277

rtanaka avatar Nov 08 '18 21:11 rtanaka

Can you help me understand the motivation for removing the links from the hardware section?

I usually treat file and directory names as atomic entities. I like to be able to search in the code for them. So, I don't see redundancy in get_archive_module.

cimryan avatar Nov 09 '18 16:11 cimryan

Can you help me understand the motivation for removing the links from the hardware section?

The readme, imho, should be streamlined to get someone set up.

You created a Wiki page with optional hardware so it made sense to me that we move all hardware links over to that wiki -- especially the optional items. We can link the actual items from the Readme to the Wiki once those pages exists.

I usually treat file and directory names as atomic entities. I like to be able to search in the code for them. So, I don't see redundancy in get_archive_module.

hmm.. okay. so, we can just leave it as is then or my other preference would be to make it an associative array instead. i can update the pull request later for that.

rtanaka avatar Nov 09 '18 23:11 rtanaka