tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

btf: improve BTF types validation

Open tixxdz opened this issue 1 year ago • 4 comments

When we perform BTF types validation, for some types we return the type name instead of the complete definition as this goes through the BTF process.

Example: To match "struct perf_event *" through BTF we can just do "perf_event"

This will silence the following warnings: msg="Kprobe spec pre-validation failed, but will continue with loading" error="validate argument 0 failed: type (perf_event) does not match spec type (perf_event)\n"

tixxdz avatar Mar 28 '23 17:03 tixxdz

You have successfully added a new CodeQL configuration .github/workflows/lint-codeql.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@tixxdz do you plan to work in this PR or should we close it?

kkourt avatar Aug 09 '23 06:08 kkourt

@tixxdz do you plan to work in this PR or should we close it?

Will fix the comments and push, I just hit this over the cred object, need to find little time

tixxdz avatar Aug 09 '23 08:08 tixxdz

@tixxdz do you plan to work in this PR or should we close it?

Will fix the comments and push, I just hit this over the cred object, need to find little time

Sounds good, thanks! Feel free to make PRs as draft if you do not plan to work on them for the foreseeable future.

kkourt avatar Aug 09 '23 10:08 kkourt