cilium
merge Config.BpfDir and Config.MapDir
You have successfully added a new CodeQL configuration .github/workflows/lint-codeql.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.
![github-advanced-security[bot] avatar](https://avatars.githubusercontent.com/in/57789?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks!
Now, we call some functions like
(option.Config.BpfDir, option.Config.BpfDir ...)(i.e. we provide the same argument twice). These includebaseSensors.Load,sensors.StartSensorManager,base.Load,sens.Load(and maybe others).Maybe in the context of this PR we should also remove the separate argument for
MapDirat these functions.
Thank you for your suggestion, I will solve it.
@Lan-ce-lot it seems that recent changes are causing conflicts. Could you rebase the PR? Thanks!
@kkourt PTAL.
@Lan-ce-lot it seems that recent changes are causing conflicts. Could you rebase the PR? Thanks!
Hey by sweeping good first issues and came upon this. What happened here, it seemed that it was approved, and checks were all successful while never merged? @Lan-ce-lot let me excuse there for the Tetragon team as it seems it was forgotten and never merged 😞.
Would you still have the energy to rebase that and merge this finally? It's okay if you don't, I would understand regarding what happened here.
