tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

Published 20 hours ago • verified publisher icon cilium

deduplicate generic type arguments

Open kkourt opened this issue 2 years ago • 6 comments

There are two versions of generic type arguments:

https://github.com/cilium/tetragon/blob/3076ae7b9cd2bbd7320af3708af240caa0fc684a/pkg/generictypes/generictypes.go#L6-L36

And

https://github.com/cilium/tetragon/blob/3076ae7b9cd2bbd7320af3708af240caa0fc684a/pkg/selectors/kernel.go#L140-L159

There seem to already be conflicts, so we should deduplicate them.

kkourt avatar Nov 04 '22 11:11 kkourt

Hey @kkourt Can I work on this issue? I am pretty new to tetragon, this would be good first issue for me.

rajaSahil avatar Dec 07 '22 06:12 rajaSahil

Hi @rajaSahil,

Go ahead if you want. I'm not aware of someone else working on it at the moment. Thanks!

kkourt avatar Dec 15 '22 16:12 kkourt

hey @kkourt can i work on this issue

SumaiyaSafdar avatar May 22 '23 19:05 SumaiyaSafdar

Hi @SumaiyaSafdar. Please sync with @rajaSahil.

kkourt avatar May 30 '23 06:05 kkourt

For info there is potential progress here https://github.com/cilium/tetragon/pull/696 but no response from the author yet.

mtardy avatar May 30 '23 08:05 mtardy

There was a first attempt here https://github.com/cilium/tetragon/pull/696 that was abandoned, I'll close the PR for now but this can be of inspiration for someone that wants to complete that :)

mtardy avatar Jan 15 '24 11:01 mtardy

This issue already solved by PR https://github.com/cilium/tetragon/pull/2168

Trung-DV avatar Apr 22 '24 15:04 Trung-DV

Indeed thanks!

mtardy avatar Apr 22 '24 15:04 mtardy