tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

Remove tetragon_msg_op_total metric

Open lambdanis opened this issue 1 year ago • 2 comments

tetragon_msg_op_total was counting events per opcode in the ring buffer queue. It wasn't particularly useful, as there are other metrics exposing similar numbers:

  • tetragon_bpf_missed_events_total counting missed events per opcode in BPF
  • tetragon_observer_ringbuf_queue_events_received_total counting total events received in the ring buffer queue
  • tetragon_events_total counting events per event type in grpc

If needed, in the future we can add opcode label to metrics counting events in the observer:

  • tetragon_observer_ringbuf_events_received_total
  • tetragon_observer_ringbuf_queue_events_received_total
  • tetragon_observer_ringbuf_queue_events_lost_total

We could also add a metric counting all events (not only missed) per opcode in BPF. However, it's unclear if they could be useful - ringbuffer and events queue shouldn't discriminate different types of events, so having total counts of successful and missed events at each stage should be enough to troubleshoot capacity issues. There is still a per event type counter at the last stage, for monitoring overall data volume.

lambdanis avatar Sep 01 '24 18:09 lambdanis

Deploy Preview for tetragon ready!

Name Link
Latest commit 74212a742c9ad98d8de3ed1f2175c36684806b3c
Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d4b28d56f49e0008bc0344
Deploy Preview https://deploy-preview-2856--tetragon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 01 '24 18:09 netlify[bot]

Converting to draft as I need to rethink how these metrics should be used.

ghost avatar Sep 02 '24 08:09 ghost