tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

Extend metrics library

Open lambdanis opened this issue 1 year ago • 1 comments

This is a general rewrite of pkg/metrics library, but it a fully backwards compatible way. Goals and key components are described in doc.go, so I would suggest starting the review there :)

For usage examples see #2604 (defining health metrics group, migrating some custom metrics & collectors to the new interface).

Fixes: #2376

lambdanis avatar Jun 24 '24 19:06 lambdanis

I pushed some commits with small fixes. I will squash the commits after the review, just didn't want to force push now.

ghost avatar Jun 28 '24 17:06 ghost

Deploy Preview for tetragon ready!

Name Link
Latest commit e0284e8bb113fd4ef6fc7472acb4132ba2977b25
Latest deploy log https://app.netlify.com/sites/tetragon/deploys/669aded4197ff600080b26bc
Deploy Preview https://deploy-preview-2606--tetragon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 03 '24 10:07 netlify[bot]

If it's not too much hassle, please fold the last commit (metrics: Simplify Group interface) with the second commit (Extend metrics library).

Sure, I think I'll squash all commits following "Extend metrics library" into it. I separated some code reshuffling into the first commit, so that it's clearer what code is new and what is just moved.

ghost avatar Jul 03 '24 11:07 ghost

I added two commits with fixes, will squash them too.

ghost avatar Jul 11 '24 13:07 ghost