tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

helm: Template CRDs directly to get standard k8s labels

Open lambdanis opened this issue 1 year ago • 1 comments

So far CRDs were included in the Helm chart like this:

  1. Copy into crds-yaml directory
  2. Concatenate in a template using .Files.Get

With such approach, Helm doesn't add standard k8s "app.kubernetes.io/*" labels (e.g. version, managed-by) to CRDs like it does for other resources. Having these labels is useful from the operational perspective, so this commit changes how CRDs are included in the Helm chart. It now works like this:

  1. Copy inside the templates directory
  2. Wrap each CRD in an if block to check if it should be included

lambdanis avatar Jun 05 '24 12:06 lambdanis

Deploy Preview for tetragon ready!

Name Link
Latest commit 23a8b3d1dd24e01bca1fb657ebcb2a85fd001a4f
Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6660600fab93a500086e7b52
Deploy Preview https://deploy-preview-2516--tetragon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 05 '24 12:06 netlify[bot]

I'll close this PR and open another one. The approach here won't work for my use cases I'm afraid.

ghost avatar Aug 15 '24 18:08 ghost