pwru icon indicating copy to clipboard operation
pwru copied to clipboard

Use clang for libpcap and CGO compilation

Open brb opened this issue 2 years ago • 5 comments

For the BPF code compilation we already use clang. Let's use the same compiler for the libpcap.a and CGO compilations.

brb avatar Jul 06 '23 07:07 brb

@brb hi I want to work on this issue can you guide me through it

swastik959 avatar Jul 09 '23 08:07 swastik959

@swastik959 Hi, thanks for taking it. A C compiler is used in the following places:

  • https://github.com/cilium/pwru/blob/main/Makefile#L19
  • https://github.com/cilium/pwru/blob/main/Makefile#L25

The issue is about using Clang for those in https://github.com/cilium/pwru/tree/main/.github/workflows.

brb avatar Jul 10 '23 07:07 brb

@brb do I only need to change the CC and LIBPCAP_CC to clang

swastik959 avatar Jul 10 '23 10:07 swastik959

Most likely yes - in the GH workflows.

brb avatar Jul 10 '23 11:07 brb

:wave: @swastik959 Any update on the issue?

brb avatar Jul 31 '23 07:07 brb