ebpf icon indicating copy to clipboard operation
ebpf copied to clipboard

Published 20 hours ago • verified publisher icon cilium

Add test suite for netkit devices

Open ti-mo opened this issue 1 year ago • 4 comments

https://github.com/cilium/ebpf/pull/1257 proposes to add support for attaching netkit programs, but we don't want to take on a dependency to vishvananda/netlink, even for testing. We've decided to drop the netkit tests for now, since the patchset is small and largely based on existing code, and kernel support isn't shipping in major distros for a while.

This issue is for 2 things:

  • add netkit support to https://github.com/jsimonetti/rtnetlink
  • add tests for the behaviour introduced in https://github.com/cilium/ebpf/pull/1257

ti-mo avatar Feb 19 '24 12:02 ti-mo

@ti-mo I can work on adding netkit support to jsimonetti/rtnetlink

brlbil avatar Feb 20 '24 12:02 brlbil

@ti-mo I can work on adding netkit support to jsimonetti/rtnetlink

Perfect! Any ETA?

ti-mo avatar Feb 20 '24 12:02 ti-mo

Not sure, I will try to push a PR upstream as soon as time allows.

brlbil avatar Feb 20 '24 14:02 brlbil

@ti-mo we will need to wait for a new version of golang.org/x/sys package which should be released soon, at least according to their release history. Netkit related symbols are there but not in a tagged version yet.

brlbil avatar Feb 26 '24 15:02 brlbil

Hi @brlbil! Any news?

lmb avatar Apr 03 '24 09:04 lmb

Hi @lmb We need some significant changes upstream. I will open an issue to discuss what would be the best way to proceed upstream.

brlbil avatar Apr 03 '24 10:04 brlbil

@lmb @ti-mo I have created an issue upstream for discussion https://github.com/jsimonetti/rtnetlink/issues/216

brlbil avatar Apr 04 '24 11:04 brlbil

The PR to merge drivers including netkit, https://github.com/jsimonetti/rtnetlink/pull/221

brlbil avatar May 04 '24 16:05 brlbil