ebpf icon indicating copy to clipboard operation
ebpf copied to clipboard

Adding additional tests for parseCPUsFromFile to cover parseCPUs test…

Open miledxz opened this issue 1 year ago • 1 comments

Why is this important ? Why to add additional tests ?

goal is to add better test coverage for parseCPUsFromFile from actual file, test cases used are from tests in parseCPUs

gentle ping for @lmb, if adding these tests make sense I can make required updates to your suggestions, thank you !

miledxz avatar Feb 15 '24 21:02 miledxz

Hi @zedGGs, does this address an existing issue? I think adding a single test for parseCPUsFromFile would be sufficient here, the test cases you added look copied from TestParseCPUs. There's no need to exercise os.ReadFile, that one already has plenty of tests and is known to work. :slightly_smiling_face:

ti-mo avatar Feb 20 '24 11:02 ti-mo

Closing for now.

lmb avatar Apr 03 '24 09:04 lmb