cilium icon indicating copy to clipboard operation
cilium copied to clipboard

ingress: Correct FromGroups rule Parsing

Open Alex-Waring opened this issue 10 months ago • 5 comments

In https://github.com/cilium/cilium/pull/30708 I created a resource that translates to a K8s resource but not to an actual resource. This PR corrects that behaviour by adding in some tests and fixing when they break. You could argue I should have done this initially, you're right.

This should be backported to 1.16 so it goes out with the original PR.

Alex-Waring avatar Apr 29 '24 12:04 Alex-Waring

/test

joestringer avatar May 01 '24 14:05 joestringer

@learnitall / @joamaki I don't think the test failures are related, mind a review please?

Alex-Waring avatar May 01 '24 15:05 Alex-Waring

This should be backported to 1.16 so it goes out with the original PR.

For now, v1.16 development continues on the main branch so no special process is required to ensure the above.

joestringer avatar May 01 '24 22:05 joestringer

Unfortunately, this will need a rebase. But thanks for catching this!

Since this is fixing an unshipped bug, no release note is required.

squeed avatar May 03 '24 12:05 squeed

/test

aanm avatar May 03 '24 14:05 aanm