cilium icon indicating copy to clipboard operation
cilium copied to clipboard

Catch ginkgo test regressions on macOS

Open aditighag opened this issue 2 years ago • 3 comments

We've had instances of PRs breaking ginkgo test runs on macOS. Add a GitHub action for darwin target to catch such regressions on the PRs introducing platform specific code changes.

Some of the options that were discussed for the GH action -

  • Run GOOS=darwin go build in the test directory as ginkgo does.
  • GOOS=darwin ginkgo -dryRun

aditighag avatar Apr 25 '22 23:04 aditighag

I was not aware how ginkgo builds the Go code. If go build in test is all it does natively, then I don't see a need for adding dependency to Ginkgo itself, like I earlier proposed (the 2nd option above).

jrajahalme avatar Apr 26 '22 06:04 jrajahalme

I can take a look at that. Can someone point me where tests are run today ? so many workflows and Makefile tasks ...

cscetbon avatar Sep 12 '22 14:09 cscetbon

@cscetbon Here is the directory where the e2e ginkgo tests are triggered - https://github.com/cilium/cilium/tree/master/test. This is how the tests are run in case you needed a reference - https://docs.cilium.io/en/latest/contributing/testing/e2e/#running-end-to-end-tests. I can assign you the issue whenever you ready to start working on it. Feel free to follow-up in the #development slack channel if you have questions, or need any feedback.

aditighag avatar Sep 19 '22 17:09 aditighag

@aditighag you can assign it to me 😉

cscetbon avatar Sep 23 '22 19:09 cscetbon

@aditighag you can assign it to me 😉

Go for it!

aditighag avatar Sep 23 '22 19:09 aditighag

@aditighag It seems it didn't like my force push with a new commit having the required sign off. I made the PR a draft for now but it needs an approval to kick off the build-commits workflow

cscetbon avatar Oct 03 '22 23:10 cscetbon