cilium-cli icon indicating copy to clipboard operation
cilium-cli copied to clipboard

Changes made to connectivity/check/logging.go

Open AHB102 opened this issue 2 years ago • 8 comments

Hi there @joestringer, I forgot to add a PR, resolved issue #2042, added context as a parameter to the failCommon method, to allow each test caller to pass their own context down when invoking Fail(), Failf(), Fatal(), and Fatalf()

AHB102 avatar Jan 05 '24 19:01 AHB102

Commit b71a58d2628a02521ad3a10a33e9a79ed2fe5a3a does not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Thanks for the PR. It doesn't build, could you fix, build and test it and re-push a fresh version?

joestringer avatar Jan 05 '24 19:01 joestringer

@joestringer I have some questions which might not be fully within the scope of this issue, so can I message you on slack ?

AHB102 avatar Jan 05 '24 19:01 AHB102

I would suggest posting in #development channel on Slack. I am not deeply involved with cilium-cli, I just noticed the issue. Posting in that public channel should provide opportunities for other developers in the community to see your messages and provide input.

joestringer avatar Jan 05 '24 19:01 joestringer

Commits b71a58d2628a02521ad3a10a33e9a79ed2fe5a3a, 05deb85de8f3eaae14a35b4caa2a5e653ea14cae do not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@christarazi Thanks for the comment! I'm quite new to open source, but I'm slowly but surely getting the hang of it.

AHB102 avatar Jan 11 '24 04:01 AHB102

@christarazi I have reworded the commit message and removed the extra line at line 316.

AHB102 avatar Jan 12 '24 11:01 AHB102

@AHB102 Seems like the code has some compilation errors.

christarazi avatar Jan 12 '24 23:01 christarazi

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 28 '24 01:09 github-actions[bot]

This pull request has not seen any activity since it was marked stale. Closing.

github-actions[bot] avatar Oct 13 '24 02:10 github-actions[bot]