cilium-cli icon indicating copy to clipboard operation
cilium-cli copied to clipboard

Add Openshift Client and List Functions

Open soggiest opened this issue 2 years ago • 4 comments

This commit adds an Openshift client to the Cilium-CLI K8s client and adds associated list commands. It seemed cleaner to create a dedicated Openshift client and add that to KubernetesClient. This keeps the k8s/client.go cleaner and easier to read.

The commit also adds mock Openshift functions. Tests can be added later.

All changes have been tested against an Openshift cluster.

The following Openshift clients are not included:

  • authorization - Likely to expose secure data
  • console - Not necessary for sysdump
  • helm - Not necessary for sysdump
  • imageregistry - Not necessary for sysdump
  • insights - Not necessary for sysdump
  • monitoring - Not necessary for sysdump
  • oauth - Likely to expose secure data
  • operatorcontrolplane - doesn't do anything
  • servicecertsigner - v1alpha - Not necessary for sysdump
  • sharedResource - v1alpha1 - Not necessary for sysdump
  • template - Not necessary for sysdump
  • user - Likely to expose secure data

soggiest avatar Mar 30 '23 02:03 soggiest

Can you fix go mod e.g. go mod tidy && do mod vendor?

I've fixed go.mod

soggiest avatar Apr 04 '23 15:04 soggiest

Commit e6a57f0c776f67bedeec4dffeb542fa80aacdac2 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

It would be awesome to see this merged anytime soon 😁 😉 .

PhilipSchmid avatar May 04 '23 16:05 PhilipSchmid

It would be awesome to see this merged anytime soon grin wink .

@soggiest the PR currently has some merge conflicts. Could you please rebase the PR's branch on latest main?

tklauser avatar May 05 '23 10:05 tklauser

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 28 '24 02:09 github-actions[bot]

This pull request has not seen any activity since it was marked stale. Closing.

github-actions[bot] avatar Oct 14 '24 02:10 github-actions[bot]