Cijo Thomas

Follow up fixes to adding Meter Tag support

3

https://github.com/open-telemetry/opentelemetry-dotnet/pull/5089 https://github.com/open-telemetry/opentelemetry-dotnet/pull/5089#discussion_r1408254794 https://github.com/open-telemetry/opentelemetry-dotnet/pull/5089#discussion_r1408263199 https://github.com/open-telemetry/opentelemetry-dotnet/pull/5089#discussion_r1408473602 - doc follow up

SDK configuration from ENV Variable

8

Spec has documented a list of ENV variable names from which SDK should read config, *if* SDK chose to support ENV var based config. https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-environment-variables.md

Make CI checks faster

7

 It looks like a good amount of time is spent on nuget restore. And majority of them from the example projects, which are not required for all the build/test...

# Issue with OpenTelemetry.Exporter.Geneva **Is this a feature request or a bug?** * [x] Feature Request * [ ] Bug https://github.com/open-telemetry/opentelemetry-dotnet/pull/5089 OTel SDK now supports Meter.Tags, but GenevaExporter is dropping...

# Issue with OpenTelemetry.Exporter.Geneva **Is this a feature request or a bug?** * [ ] Feature Request * [x] Bug Enforce the key length limitation, and emit a log. https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs#L697-L700...

AppService resource when slot swap occurs

2

**Is this a feature request or a bug?** Both! **What is the expected behavior?** Slot swaps may not be handled correctly as env variables won't change when slot swaps. https://github.com/microsoft/ApplicationInsights-dotnet/issues/1368...

FlakyTests

3

Flaky test: [xUnit.net 00:00:02.01] OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/api/value", url: "http://localhost/api/value", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False, filter: "{ThrowException}", recordException: False) [FAIL] Failed OpenTelemetry.Instrumentation.AspNet.Tests.HttpInListenerTests.AspNetRequestsAreCollectedSuccessfully(expectedUrl: "http://localhost/api/value", url: "http://localhost/api/value", routeType: 0, routeTemplate: null, setStatusToErrorInEnrich: False,...

Flaky test

2

[xUnit.net 00:00:00.53] Starting: OpenTelemetry.Extensions.Tests [xUnit.net 00:00:00.86] OpenTelemetry.Extensions.Tests.Trace.AutoFlushActivityProcessorTests.AutoFlushActivityProcessor_FlushAfterLocalServerSideRootSpans_EndMatchingSpan_Flush [FAIL] [xUnit.net 00:00:00.86] Moq.MockException : [xUnit.net 00:00:00.86] Expected invocation on the mock once, but was 2 times: mock => mock.OnForceFlush(5000) [xUnit.net 00:00:00.86] [xUnit.net...

Flaky test again

4

[xUnit.net 00:00:02.23] OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [FAIL] [xUnit.net 00:00:02.23] Assert.Equal() Failure [xUnit.net 00:00:02.23] Expected: 1997.0201999999999 [xUnit.net 00:00:02.23] Actual: 0 [xUnit.net 00:00:02.23] Stack Trace: [xUnit.net 00:00:02.23] D:\a\opentelemetry-dotnet-contrib\opentelemetry-dotnet-contrib\test\OpenTelemetry.Instrumentation.EventCounters.Tests\EventCountersMetricsTests.cs(74,0): at OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter() Failed OpenTelemetry.Instrumentation.EventCounters.Tests.EventCountersMetricsTests.EventCounter [1 s] Error...

Only some has links to nuget in main readme: Eg: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Exporter.Instana#readme Some do not have link to nuget: Eg: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Extensions.Docker#readme https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Instrumentation.AWSLambda Opening to track making all readme files consistent.