Jan Uhlář

Results 12 comments of Jan Uhlář

I think I found the issue, not sure, but if I change in the Context#extract_correlated_key to detect children its working.. ``` when Arel::Nodes::And if join_root.children.any? join_root.children.each do |child| eck =...

> @ciihla thank you for this contribution, is it possible to add a test (that would fail first without your PR) ? The test is very specific, maybe it has...

I think I found the issue, not sure, but if I change in the Context#extract_correlated_key to detect children its working.. when Arel::Nodes::And if join_root.children.any? join_root.children.each do |child| eck = extract_correlated_key(child)...

I don't have time for writing proper tests, etc, but basically, this is working for us: ``` module RansackPatch def self.included(base) base.class_eval do alias_method :extract_correlated_key, :extract_correlated_key_with_children_support end end def extract_correlated_key_with_children_support(join_root)...

https://github.com/activerecord-hackery/ransack/pull/1279/files

We have few domains that dont have SPF record but are valid email servers. And since version 1.1.3 we are not able to deliver emails to them. We had to...

That would be ideal. Regarding the question whether to use `Griddler::Configuration` or own config: I would go with own config. Because otherwise we would force other adapters to implement the...

I just thought that functionality of one gem would depend on configuration of other gem, but maybe I understand it wrong and its okay.. Anyway thank you for your willingness!

If you pointed that its a de-facto a parent, you are right. It makes sense to me too now. Although both options make sense to me :) On the other...

Thats good point too. You are right..