CL Fisher

Results 1061 comments of CL Fisher

Enable csv import of partners with six fields

Hey @McEileen -- don't know if this is supposed to be ready for review, but partner 9 in the earlier attached csv should show a warning, and isn't.

Enable csv import of partners with six fields

Hey @McEileen -- are you still working on this?

Enable csv import of partners with six fields

Hrm. I'm seeing different results. If I run setup, then check with [email protected], I get If I then check with [email protected], I get: (Edit) However, if I run set up...

Enable csv import of partners with six fields

Some thoughts on the situation above: 1/ I suspect that [email protected] doesn't have a default storage location set, whereas [email protected] might. 2/ That we didn't get *any* errors on importing...

Enable csv import of partners with six fields

But/and this raises bigger questions. (IIRC, we do not currently allow partners to send requests to multiple banks) so I'm ccing in @awwaiid.

Enable csv import of partners with six fields

Also ccing in @ruestitch For *this* PR, it looks to me like we are failing silently if the partner to be imported already exists on another bank. I suggest that...

4977 add ability to delete unused item categories

Looks good functionally. Over to @dorner for technical input.

Adding reporting categories to items (and base items)

Only those mentioned. It is possible that we may add reporting categories in the future, but this is essentially something so they can say how it gets counted in the...

Adding reporting categories to items (and base items)

I'm fine with that -- it was almost certainly a slip of the fingers.

Adding reporting categories to items (and base items)

not stale. I think it's waiting for something from me