CL Fisher
CL Fisher
pinging @jadekstewart3 on this -- there was an open question.
I looked into it -- the agency information partial is always shown -- several of the others are controlled by the bank choosing whether the partners see them or not....
@jadekstewart3 Ummm.. no - the moving of the fields is still necessary -- what isn't necessary is the extra work of making your new partial optional -- because the original...
I just edited a partner as [email protected] on staging, and there is a "Program / Delivery Address (if different)". I think we added in the Delivery bit after the issue...
Yeah -- the CI also calls erblint, (the command in ci seems to be Run bundle exec erblint --lint-all) . This is catching a trailing newline in app/views/partners/profiles/edit/_agency_information.html.erb:58
Hey @jadekstewart3 -- going ahead and kicking the tires on this -- I figure the erblint issue noted above will be exceedingly minor to fix. Please check throughout that the...
I've got a block of work on HE slotted for tomorrow, will try to get to this then.
LGTM -- @dorner.. Do you want to take a quick look for any technical concerns?
Hey @fchatterji -- I notice that you say it's WIP because some barcode tests are still failing. If they fail sometimes, but not always, that's a known issue we have...
Hey @fchatterji -- Just checking in because it's been a couple of weeks -- how is this coming along?