Cider-2 icon indicating copy to clipboard operation
Cider-2 copied to clipboard

Last.fm "Remove Featured Artists" and "Remove Album Extensions" also affects Discord RPC

Open n-1-c-k-y opened this issue 1 year ago • 2 comments

Preflight Checklist

  • [X] I agree to follow the Code of Conduct that this project adheres to.
  • [X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • [X] I have checked that the correct behavior occurs on Apple Music Web (if applicable).
  • [X] I have verified that my issue is with a supported version and that it is with the desktop app (Support for other areas can be found in our Discord / on the appropriate repo).

Download Source

Microsoft Store / Discord

Operating System

Windows, Tested it on Linux too

Commit Hash

No response

Connect Instance ID

No response

Build Timestamp

No response

Describe the Bug

When your LFM account is connected and the track adjustments 'Remove Featured Artists' and 'Remove Album Extensions' are enabled, it will also affect the Discord RPC, removing the featured artists and the album extensions in the RPC too.

Steps to Reproduce

  1. Connect LFM account
  2. Enable 'Removed Feature Artists' or 'Remove Album Extensions' in Track Adjustments
  3. Check the Discord RPC

Anything else?

image (Disabled) image (Enabled)

n-1-c-k-y avatar Jun 05 '24 06:06 n-1-c-k-y

Should be fixed in 2.4.2

coredev-uk avatar Jun 18 '24 23:06 coredev-uk

Should be fixed in 2.4.2

I just tested the new .NET version, and this still happens. Was it fixed only for Sabiiro/Electron?

n-1-c-k-y avatar Jul 02 '24 19:07 n-1-c-k-y

This issue is stale. If this issue is still occurring and you are on a supported version, please leave any comment (e.g. "bump") within the next 7 days and the issue will remain open. If you have any additional information that may help us resolve your issue, please include it with your comment.

cider-collective[bot] avatar Nov 17 '24 02:11 cider-collective[bot]

bump

n-1-c-k-y avatar Nov 18 '24 09:11 n-1-c-k-y

@n-1-c-k-y can you test on the latest experimental Linux build please

coredev-uk avatar Nov 21 '24 02:11 coredev-uk

I just tested it and it's still doing the same thing.

{"version":"2.5.4","commit":"5619924b8d8c8cede3fb3696210c8b5b99bb81b1","buildDate":"1732130632027","framework":"genten","isDev":"production","platform":"linux","platformFriendly":"Linux","platformVersion":"6.6.59-1-lts","arch":"x64","port":"10767","steamdeck":false,"clientVersion":"2.0.0","protocolVersion":"4","capi":"csevd680hwh903mtglciytiw"}

n-1-c-k-y avatar Nov 21 '24 04:11 n-1-c-k-y

@n-1-c-k-y I have just pushed another build to Taproom. Give that a try, but be aware that Taproom has been caching builds, so make sure you clear your cache and make sure the checksum or file creation date does not match your current build.

coredev-uk avatar Nov 21 '24 10:11 coredev-uk

I think it is now completely broken

n-1-c-k-y avatar Nov 21 '24 15:11 n-1-c-k-y

Yeah I did break lastfm, a build was just pushed that should fix it. In my testing this issue is no longer present

coredev-uk avatar Nov 21 '24 15:11 coredev-uk

Great, thank you for fixing it.

n-1-c-k-y avatar Nov 21 '24 15:11 n-1-c-k-y

So I take it that this issue is resolved for you then? @n-1-c-k-y

coredev-uk avatar Nov 21 '24 15:11 coredev-uk

My bad, I thought it didn't happen anymore in your tests; I just tested it and it's still doing the same thing.

n-1-c-k-y avatar Nov 22 '24 03:11 n-1-c-k-y

What build did you use, because it is physically impossible for it to happen in the latest. Please remove the update.zip in your appdata and use the latest experimental genten build

coredev-uk avatar Nov 23 '24 04:11 coredev-uk

What build did you use, because it is physically impossible for it to happen in the latest. Please remove the update.zip in your appdata and use the latest experimental genten build

I'm using the latest experimental appimage.

image image image

With remove featured artists disabled: image

I already tried deleting the sh.cider.genten folder entirely, and it didn't work.

{"buildInfo":{"version":"2.5.4.0","commit":"1222aefb3170dac55de90fb4b08a5bf95632152b","buildDate":"1732280265092","changelogUrl":"2.5.0-release"},"clientInfo":{"client":"genten","env":"production","arch":"x64","platform":"linux","platformFriendly":"Linux","build":"desktop","clientVersion":"2.0.0","capi":"j1i9i4gguakzsrk1mmyuuj4k"}}

n-1-c-k-y avatar Nov 24 '24 10:11 n-1-c-k-y

I was getting an older build; I downloaded and extracted the rpm, and I got a more recent build, yet the issue persists.

{"buildInfo":{"version":"2.5.4.0","commit":"38f06753747557498950f0d3fd765ba33580bab9","buildDate":"1732335990530","changelogUrl":"2.5.0-release"},"clientInfo":{"client":"genten","env":"production","arch":"x64","platform":"linux","platformFriendly":"Linux","build":"desktop","clientVersion":"2.0.0","capi":"q2ccb55h2m2xkgte1wi4tsiy"}}

n-1-c-k-y avatar Nov 24 '24 11:11 n-1-c-k-y

Okay, I finally see what you mean. It seems the mutations we were making to the event object were being carried to the main musickit nowplayingitem, which is incredibly stupid. I have made a fix that clones it. Sorry about the confusion

coredev-uk avatar Nov 25 '24 06:11 coredev-uk

It looks like it's broken again and not removing the featured artists in the scrobbles now. image image image

n-1-c-k-y avatar Nov 25 '24 10:11 n-1-c-k-y

Ill add the check in, didnt think isCloudItem would not be present

coredev-uk avatar Nov 25 '24 15:11 coredev-uk

The build is currently uploading to Taproom, should fix this @n-1-c-k-y

coredev-uk avatar Nov 25 '24 19:11 coredev-uk

Maybe I got an older build, but it's still not fixed 💀

image image image

n-1-c-k-y avatar Nov 25 '24 21:11 n-1-c-k-y

Can you dump your client info please

coredev-uk avatar Nov 26 '24 00:11 coredev-uk

{"buildInfo":{"version":"2.5.4.0","commit":"567c093108cedfd257e38827d930967145e238f3","buildDate":"1732562340408","changelogUrl":"2.5.0-release"},"clientInfo":{"client":"genten","env":"production","arch":"x64","platform":"linux","platformFriendly":"Linux","build":"desktop","clientVersion":"2.0.0","capi":"uohekx3pan1wy5x8vxiv2joq"}}

This?

n-1-c-k-y avatar Nov 26 '24 01:11 n-1-c-k-y

Yeah, thanks. It seems the object cloning didnt do anything, Im working on restructuring the function so it should work, i'll let you know when the builds are up.

coredev-uk avatar Nov 26 '24 01:11 coredev-uk

No problem, happy to help.

n-1-c-k-y avatar Nov 26 '24 01:11 n-1-c-k-y

Ok, I've just committed it, give it about 5-10 minutes to build, check the build time on taproom.

coredev-uk avatar Nov 26 '24 01:11 coredev-uk

Yeah, it's fixed now, thanks!

n-1-c-k-y avatar Nov 26 '24 13:11 n-1-c-k-y