ember-basic-dropdown icon indicating copy to clipboard operation
ember-basic-dropdown copied to clipboard

Types need to be published

Open tansongyang opened this issue 3 years ago • 2 comments

We're using Ember with TypeScript. Got latest this morning (v4.0.5) and we can't compile because TS can't find the types for ember-get-config. Looking in my node_modules, I can confirm that the types directory is missing.

I believe the fix involves adding "types": "./path/to/index.d.ts" in the package.json, though there may be more steps.

image

tansongyang avatar Mar 25 '22 15:03 tansongyang

I'd rather see ember-get-config removed again. v1 and v2 were made in an attempt to make the addon compatible with Embroider, but at the moment, it isn't. The reason why people think it's compatible with Embroider is because Embroider ships with a compat adapter for ember-get-config. Disabling the compat adapter shows that the addon is not yet compatible on its own. Also, the config object returned isn't an actual reference to the app's config. Resolving the config via the owner (like it was before) is still the best and safest way to get the app's actual config object and doesn't require an additional dependency.

bertdeblock avatar May 29 '22 21:05 bertdeblock

now that we've fixed ember-get-config I'm trying to get a few fixes backported with https://github.com/cibernox/ember-basic-dropdown/issues/671

mansona avatar Jul 21 '22 09:07 mansona