ember-basic-dropdown icon indicating copy to clipboard operation
ember-basic-dropdown copied to clipboard

fails to build in ember 3.27.0

Open BryanCrotaz opened this issue 4 years ago • 12 comments

Template Compiler Error (broccoli-persistent-filter:TemplateCompiler) in ember-basic-dropdown/templates/components/basic-dropdown/content.hbs

Assertion Failed: [BUG] seen set should be available

Builds ok in 3.20.0 (used ember-cli-update to do the upgrade)

BryanCrotaz avatar Jul 04 '21 14:07 BryanCrotaz

Seeing the same error, except is fails in 3.20.0 as well.

gabivoicu avatar Jul 28 '21 15:07 gabivoicu

@BryanCrotaz if you are seeing this while installing ember-paper, this happens because ember paper uses an old version of the addon https://github.com/miguelcobain/ember-paper/blob/master/package.json#L68 (2.0.15)

The latest version of this addon is 3.0.19

juanazam avatar Aug 10 '21 20:08 juanazam

@juanazam Do you know if there is a way to manually set the ember-paper dependency to that specific version?

icheered avatar Aug 15 '21 22:08 icheered

@icheered you can pin the version using resolutions if you use yarn, but the version ember paper uses is too old to do that

juanazam avatar Aug 16 '21 00:08 juanazam

also getting failure after updating to 3.27.0, any suggestions?

TypeError: Cannot read properties of undefined (reading 'args')
                at initializer (https://0.0.0.0:7357/assets/vendor.js:99689:19)
                at getter (webpack://__ember_auto_import__/./node_modules/@glimmer/validator/dist/modules/es2017/lib/tracking.js?:88:15)
                at BasicDropdown.get [as isOpen] (webpack://__ember_auto_import__/./node_modules/@glimmer/tracking/dist/modules/es2017/src/tracked.js?:107:14)
                at BasicDropdown.get publicAPI [as publicAPI] (https://0.0.0.0:7357/assets/vendor.js:99405:22)
                at getPossibleMandatoryProxyValue (https://0.0.0.0:7357/assets/vendor.js:13809:19)
                at _getProp (https://0.0.0.0:7357/assets/vendor.js:13874:17)
                at https://0.0.0.0:7357/assets/vendor.js:49294:45
                at https://0.0.0.0:7357/assets/vendor.js:49242:37
                at track (https://0.0.0.0:7357/assets/vendor.js:58931:7)
                at valueForRef (https://0.0.0.0:7357/assets/vendor.js:49241:44)

I'm still on 1.X of ember-auto-import in case that matters, not using embroider yet (I don't have the imports/haven't even looked at how to configure)

erichaus avatar Sep 06 '21 22:09 erichaus

@burritoIand seems you are using an old version of the addon, the newer ones work with 3.27

juanazam avatar Sep 06 '21 22:09 juanazam

@juanazam image I didn't investigate further but I'll try again tonight or tomorrow.. all I know is my test suite had multiple failures with same message above after bumping to ember 3.27

erichaus avatar Sep 07 '21 00:09 erichaus

Check with ember-dependency-lint that you don't have multiple versions loaded

BryanCrotaz avatar Sep 07 '21 07:09 BryanCrotaz

@BryanCrotaz ok will check, loaded the app and saw this: image

running ember dependency lint image

is that mismatch related possibly?

edit

fwiw I tried updating to glimmer component 1.0.4 and that didn't fix it

erichaus avatar Sep 07 '21 08:09 erichaus

@burritoIand I also ran into the Cannot read property 'args' of undefined error when I updated to ember 3.27. I found that I had conflicting resolutions for @glimmer/tracking in my lockfile, causing both 1.0.1 and 1.0.4 to be available. I massaged the lockfile to get all references to resolve to 1.0.4, and the error went away.

timmorey avatar Oct 12 '21 13:10 timmorey

@timmorey ok thank you I will try that!

erichaus avatar Oct 12 '21 21:10 erichaus

Seen this upgrading ember-source from 3.24.8 to 3.28.5 using 4.0.3 of this addon.

kategengler avatar Feb 17 '22 20:02 kategengler

Closing this issue, as this bug was reported with v3 / v4 and maybe also already fixed with dependencies

If it is still present with v8 (and ember v3.28+) let me know

mkszepp avatar Mar 15 '24 16:03 mkszepp