Marco Ciampini

Results 134 comments of Marco Ciampini

All currently known `exhaustive-deps` violations in the components package should be fixed 🎉 Let's rebase and see if we're able to enable this rule for the package! One thing: currently...

I guess the last thing to decided is whether we should `warn` or `error` for this rule — @tyxla do you have any opinions / suggestions on this one?

> Looks like `FooterMessageControl` is native only at this point? Good point, I'm going to remove it from the list.

Sure. You can find the slides [here](https://docs.google.com/presentation/d/1Ps_NAbf07dOcjv_emIMpE5B9hqEIRtwvCAfMcUS_I_Y/edit?usp=sharing). I'll post again when the video is ready (it's in the process of being edited at the moment) Thanks, Marco

Hi, the video has just been uploaded, excuse me for the delay. [video](https://youtu.be/gAJXNv40ONc?t=6m40s) [deck](https://docs.google.com/presentation/d/1Ps_NAbf07dOcjv_emIMpE5B9hqEIRtwvCAfMcUS_I_Y/edit?usp=sharing) Thanks, Marco

Looks like playwright CI tasks got stuck.. maybe you can push a new commit to force them to re-run ?

Opened https://github.com/floating-ui/floating-ui/issues/2171 to get the conversation started about implementing the overlay functionality directly in `floating-ui`

Update: the `floating-ui` authors decided against supporting `overlay` placement (or a similar feature) directly in the library — https://github.com/floating-ui/floating-ui/issues/2171#issuecomment-1425292789

`center` to me suggests centering reference and floating, but without affecting the floating size IMO, if we want to keep the current `overlay` behaviour within `Popover`, (ie. the floating element...

> The changes in this PR introduced the following warning when switching the device types in the Site Editor. > > ``` > Warning: Removing a style property during rerender...