Marco Ciampini
Marco Ciampini
> @jameskoster @ciampo is there anything we can do to move this PR forward? I'll be having another look at this PR soon. Unfortunately I've been very busy lately and...
Apologies if my suggestion wasn't clear enough — I meant the `@wordpress/components` package's CHANGELOG: ```diff diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index d2da776b33..854c823db4 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -34,6 +34,10 @@...
> @ciampo Thanks for your clarification! I added the changelog entry and update the PR with the latest `trunk` again. Awesome! I'll merge when CI is ✅ Thank you again!
Just chiming in with a thought re. the greyed out component — greyed out controls are usually an indication that the control is `disabled`, wouldn't the current design break this...
> @ciampo, there are still 60-ish test files that use `enzyme`. Is it something you want to have replaced with RTL universally? I'd love to, but currently don't have the...
Thank you! This PR definitely improved `Tooltip`'s tests!
I think an important consideration to make when implementing such a feature (and the reason why `colord` may not support it yet) is that the computation of contrast/readability should take...
Update: as @t-hamano pointed out in https://github.com/WordPress/gutenberg/pull/47373#issuecomment-1404555650 , the `mix` plugin could be used to calculate the compound color, which can then be fed to the relevant `a11y` util
@benoitgrelard just to make sure I'm not missing anything here: what if there simply isn't enough space in the viewport to show the full dropdown menu? Is it possible to...
Same problem here. Tests won't run in Safari unless I select it as the foreground app