Marco Ciampini

Results 134 comments of Marco Ciampini

Makes sense to me — let's merge once CI is ✅ !

cc @mirka @chad1008 and a few devs who have been recently working often with the `@wordpress/components` package @aaronrobertshaw @andrewserong @talldan @ntsekouras

Thank you for your replies, @aaronrobertshaw and @mirka ! It looks like we may be converging towards this proposed solution: > A potential solution could be to expose only high-level...

> would we then encourage folks to use their own flex or grid CSS styling particular to the component they're writing (perhaps attached to `View` components) over using `Flex` directly?...

> > in the site editor, the toolbar keeps shifting up (when scrolling down) — while in the post editor, it stops once it goes beyond the block's top edge...

Update: I believe the unexpected behavior that I flagged above could be related to a limitation of the `floating-ui` library — I opened https://github.com/floating-ui/floating-ui/issues/1859 to hopefully get more insights (and...

I did some more testing, and I believe that the only way to get the to the behaviour that we want (while generalizing it enough to work for different `placements`)...

@ntsekouras and @talldan , I believe this is ready for another round of review. I've updated the PR description too, for more details on the solution i'm proposing.

I personally prefer the current approach in this PR more, because: - the way we are applying the frame offset in the `offset` middleware was hacky anyway (we were already...

> Do you think this is something that could land quite soon and we could wait? Difficult to tell at the moment, it will mostly depend on what the library...