Marco Ciampini
Marco Ciampini
cc'ing @brookewp as she's been also looking at how to best take transparent values into account when computing accessible contrast with `colord`
It seems to be working well! I think we can refine this approach in a few ways: 1. We could move it to a separate utility (ie. `getCompositeBackgroundColor` or something?)...
Thank you for chiming in, Brooke! > which yielded nearly identical results. However, your solution is much cleaner. :) Awesome! The timing of the two of you working on these...
Mhh, it looks like CSS custom properties [are not fully supported in jsdom](https://github.com/jsdom/cssstyle/issues/89). In case we can't write tests at the component level, we could at least write unit test...
A rebase/merge with `trunk` should hopefully solve the CI failures (and the conflicts) — after that, we should be ready for final review & approval!
Hey @mike-day , thank you so much for starting the work on this! I will try to come back with a proper review later, but for now I just wanted...
Thank you for the ping, @jasmussen ! > Also I noticed that when you click the plus to add a new style, I can type in the text but not...
Merged for you :) Thank you again @corentin-gautier for your help and patience in tweaking your proposed solution!
cc'ing @youknowriad @tyxla and @jsnajdr , in case this issue can be related to existing issues (or is a duplicate of an existing one)
Hey @corentin-gautier , thank you for opening those PRs! Just wanted to let you know that I won't be around to continue reviewing those PRs in the next weeks, but...