readline Fix a race condition in terminal.go

Fix a race condition in terminal.go

Open wallaceicy06 opened this issue 6 years ago • 2 comments

There is a race condition in terminal.go relating to wait groups. The wg.Add method should be called by the parent goroutine, not the child.

https://golang.org/pkg/sync/#WaitGroup

This was caught by gotsan.

See #122

Aug 06 '18 21:08 wallaceicy06

Bump.

Oct 16 '18 17:10 wallaceicy06

@Alkorin is it possible to merge this?

Feb 07 '19 07:02 wallaceicy06