grunt-inline icon indicating copy to clipboard operation
grunt-inline copied to clipboard

refactor tests

Open tenaciousRas opened this issue 8 years ago • 0 comments

Expected: Project is written with testable code that doesn't require integration test that use file-comparison (which is very brittle) to validate regex. For example, in inline.js, isolate all methods that match on regex whenever possible, and unit test them with minimal dependencies that can be injected if necessary.

Actual: "grunt test" uses integration tests as a way to validate regex matching. This is a poor practice. It's up to you to ask a project contributor how to de-couple the dependencies and write better tests.

versions:

  • affects all versions of this project

tenaciousRas avatar Sep 29 '16 10:09 tenaciousRas