NanoLedger
NanoLedger copied to clipboard
chvp
Allow edit postings notes
Since #223 the notes on transactions are stored and not deleted when editing a transaction, but it would be nice if we can add or edit a note on a posting from the app.
Currently I have implemented a simple way to edit notes, but before opening a PR I wanted to know the developer opinion. I've added a button on each PostingRow to show a Dialog with the note. This allows to create/edit/delete a note in a posting.
I am no graphic designer, but if you think this will be a nice feature I can made a PR.
I'm not opposed to adding the functionality of editing comments, but I'm not a big fan of the UX as implemented in that screenshot. I personally feel that the row for postings is already constrained horizontally in size, so adding another button to that will only make that problem worse. I'm also just not a big fan of hiding this behind a dialog.
If/when this is added, each posting should probably be multiple rows. This would also give more space for things like balance assertions, posting status, costs, ...
Yes, the horizontal size is already an issue even before the extra button. I agree the UI needs a rework—that might even be appreciated without posting notes enabled.
Yeah, I also thought that is constrained horizontally. What do you think about a design that when you select a posting, additional rows associated to that posting appears (for balance assertion, notes, etc). As you say, that way the horizontal space would not be a problem, and also in the settings we can add a check for something like "Simple/Complex UI", just in case somebody just want the basic posting view and does not want/use all of that information
That was along the lines of what I had in my head as the best idea I could think of. I didn't love it so I didn't bother suggesting it, but also I couldn't think of anything better.
The other idea I was toying with was having just the account on one row and everything else related to the posting in a second row.
Something like that sounds good to me. I'm not a UI expert either, I usually just experiment a bit with different layouts and see what I like the best.