Christian Vogl

Results 7 comments of Christian Vogl

@sonachitchyan I guess we can close this?

Thanks a lot for offering to work on this. You are more than welcome to open a PR. You can follow the [TARDIS developer workflow](https://tardis-sn.github.io/tardis/contributing/development/git_workflow.html).

I agree that `time_explosion` is a bit confusing. However, I would prefer `time_since_explosion` to `time_of_spectrum`.

I agree with @wkerzendorf that time_of_spectrum is somewhat ambiguous regarding the zero point.

@hrithik18236 One important process in the ejecta of exploding stars is the excitation of atoms by collisions with electrons. The excited atoms can then emit photons, which we can use...

@hrithik18236 The P_EMISSION_DOWN etc. have nothing to do with the GFALL_AIR_THRESHOLD. They are relevant for how Carsus/Tardis treats atomic transitions in the macro atom scheme.

@hrithik18236 The data is still stored in both locations. You can work on this issue if you want to. You can start by finding out which version of the zeta_data...