Chunfu Wen

PASS 1-type_specific.io-github-autotest-libvirt.virtual_disks.nvme.coldplug.attach_nvme PASS 2-type_specific.io-github-autotest-libvirt.virtual_disks.nvme.hotplug.attach_nvme

merge it since all reviewers approved it

previously failed log 2022-11-25 18:07:38,139 stacktrace L0045 ERROR| run_func(self, params, env) 2022-11-25 18:07:38,139 stacktrace L0045 ERROR| File "/var/lib/avocado/data/avocado-vt/virttest/test-providers.d/downloads/io-github-autotest-libvirt/libvirt/tests/src/virtual_disks/virtual_disks_rotation_rate.py", line 101, in run 2022-11-25 18:07:38,139 stacktrace L0045 ERROR| virsh.detach_device(vm_name, disk_xml, debug=True,...

Command 'virsh list' finished with 0 after 0.028771795s cleaning libvirtd logs... DATA (filename=output.expected) => NOT FOUND (data sources: variant, test, file) DATA (filename=stdout.expected) => NOT FOUND (data sources: variant, test,...

@smitterl , libvirt.create_disk_xml(disk_dict) is heavily used across different python files, the root clause could be in libvirt.create_disk_xml(disk_dict) itself, but we do see very few happening in other places. So here...

@smitterl your comment is replied, please double check

@smitterl please check replied comment

We may need use try ... except when import since tp-libvirt also need keep compatibility with lower avocado version, eg. 92lts ``` try : from avocado.utils.software_manager import SoftwareManager except: from...

@iccaszhulili please help double check this

We'd better not export module under src folder of tp-libvirt as package to allow be imported by other test case module(as https://github.com/autotest/tp-libvirt/pull/3343), this may lead to module import relationship mess....