Chuck Daniels

Results 111 comments of Chuck Daniels

@adam-arold I'm totally with you on this point. TL;DR; I'd be happy to help with this effort of creating meaningful/helpful examples where they're needed, if such contributions are welcome. I...

I'm on macOS 12.5.1 using Python 3.10 and I get the same error.

@itamarst x86 via conda. However, after I read the discussion you linked, I installed via pip and it worked, but I just wanted to add that via conda, I also...

I'm glad to see `excludes` is supported. However, the addition to the docs doesn't provide any details on what type of value is supported. Is the `excludes` value a list?...

I believe only the signature should be corrected as initially suggested, and that the implementation should be left alone. Since a url param key is allowed to be duplicated (and...

It looks like you should simply change the default value of `read_timeout` to `aiohttp.client.sentinel` (like you do for `timeout`) instead of `None`.

As a means to silence the deprecation warning, we can do this, for example: ```python import aiohttp from pfun.http import HTTP class Env: http = HTTP(read_timeout=aiohttp.helpers.sentinel) ``` Notice also that...

I see that both `read_timeout` and `conn_timeout` were deprecated in [aiohttp 3.5.0 (2018-12-22)](https://github.com/aio-libs/aiohttp/blob/fe92cecbb03bcc8fe0ae46e9942068bfcbe6e87a/CHANGES.rst#350-2018-12-22), so perhaps these should be removed from the `pfun.http.HTTP` constructor altogether (or at least deprecated in `pfun`...

I would love for this to be merged and released. Any reason this hasn't been merged?

As an example of one of the files: ``` >>> import xarray as xr >>> from datetime import date >>> url_pattern = ( ... "https://dap.ceda.ac.uk/neodc/esacci/land_surface_temperature/data/" ... "MULTISENSOR_IRCDR/L3S/0.01/v2.00/monthly/{time:%Y}/{time:%m}/" ... "ESACCI-LST-L3S-LST-IRCDR_-0.01deg_1MONTHLY_DAY-{time:%Y%m}01000000-fv2.00.nc" ......